[Octave-bug-tracker] [bug #50463] gsvd implementation uses functions removed from lapack >= 3.6.0

[Mike Miller]

Follow-up Comment #43, bug #50463 (project octave):

Sure. With the default BLAS on Debian (with deprecated symbols included):


have_DGGSVD3: 1
have_DGGSVD: 1
have_DGGSVD123: 0


With a BLAS library built without deprecated symbols:


have_DGGSVD3: 1
have_DGGSVD: 0
have_DGGSVD123: 0


And with this change I get no segmentation fault, because it is no longer
checking "if (! dyn_libs)".

I also made a local change to test, without this patch, with the following
change instead, the correct function was found and used:


--- a/liboctave/util/oct-shlib.cc
+++ b/liboctave/util/oct-shlib.cc
@@ -182,7 +182,7 @@ namespace octave
     // normally throw an exception, avoiding the construction of an invalid
     // library.  Leave it here for possible future use.
 
-    bool is_open (void) const { return (library != nullptr); }
+    bool is_open (void) const { return (search_all_loaded || library !=
nullptr); }
 
   private:
 


There is no need to make the file property public, there is already a
file_name accessor method in both the facade class and the rep base class.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?50463>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/