[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #52988] Variable editor: allow scalars to be s

From: Dan Sebald
Subject: [Octave-bug-tracker] [bug #52988] Variable editor: allow scalars to be shown directly
Date: Sun, 11 Feb 2018 13:46:36 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Follow-up Comment #26, bug #52988 (project octave):

There may be some cruft left over from changes associated with this bug. 
There is no slot connected to the following signal:

linux@ ~/octave/octave/octave $ grep maybe_resize_columns * -sir
libgui/src/variable-editor-model.cc:  emit maybe_resize_columns_signal ();
libgui/src/variable-editor-model.h:  void maybe_resize_columns_signal (void);

I.e., the following doesn't do anything:

linux@ ~/octave/octave/octave $ hg diff
diff --git a/libgui/src/variable-editor-model.cc
--- a/libgui/src/variable-editor-model.cc
+++ b/libgui/src/variable-editor-model.cc
@@ -1206,8 +1206,6 @@ variable_editor_model::update_data (cons
   emit dataChanged (QAbstractTableModel::index (0, 0),
                     QAbstractTableModel::index (new_display_rows-1,
-  emit maybe_resize_columns_signal ();
diff --git a/libgui/src/variable-editor-model.h
--- a/libgui/src/variable-editor-model.h
+++ b/libgui/src/variable-editor-model.h
@@ -261,8 +261,6 @@ signals: // private
   void user_error_signal (const QString& title, const QString& msg) const;
-  void maybe_resize_columns_signal (void);
   void set_editable_signal (bool);
   void description_changed (const QString& description);

Was there something added and then removed inadvertently?


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]