[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #53155] keyboard focus is no longer on the com

From: John W. Eaton
Subject: [Octave-bug-tracker] [bug #53155] keyboard focus is no longer on the command window by default
Date: Wed, 14 Feb 2018 11:59:59 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

Follow-up Comment #2, bug #53155 (project octave):

I noticed this a few days ago, bisected, and found that this changeset is what
did it:

# HG changeset patch
# User Torsten <address@hidden>
# Date 1518369262 -3600
#      Sun Feb 11 18:14:22 2018 +0100
# Node ID 981990aaa93191849f64a811853d6cca529cc6db
# Parent  5d8c4cbc56d705007c54a1357e2a48ada9aa6782
* webinfo.cc (tab_state_changed): set focus to current tab after tab removal

diff --git a/libgui/src/qtinfo/webinfo.cc b/libgui/src/qtinfo/webinfo.cc
--- a/libgui/src/qtinfo/webinfo.cc
+++ b/libgui/src/qtinfo/webinfo.cc
@@ -229,6 +229,7 @@ namespace octave
     _close_action->setEnabled (_tab_bar->count () > 1);
     _close_others_action->setEnabled (_tab_bar->count () > 1);
     setFocusProxy (_stacked_widget->currentWidget ());
+    setFocus ();

   void webinfo::current_tab_changed (int index)

I asked Torsten about it privately because I thought it would be a simple fix.
 If not, then let's undo this, because whatever problem it fixes can't be as
bad as the command window not having the focus at startup.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]