[Octave-bug-tracker] [bug #53046] Variable Editor: feature request to make multiple tables visible at once.

[Dan Sebald]

Follow-up Comment #24, bug #53046 (project octave):

Several signal/slot connections got lost in the shuffle.  I went through the
features I'm aware of from looking at the code and confirmed they are working
again.  I also restored the "level up" button, now that I know more about what
it is supposed to do.

I also undid this


" (%1); title (\"%2\");"


for the title, having realized that I could use %1 more than once.

With your example, I experimented a bit and I see that the plotting will fail
when what is displayed in the QTableView is a cell array.  I.e., "plot(%1)"
doesn't work for %1 that are cells, just matrices.  Feature-wise the V.E.
should be able to translate to plottable format, but I can see looking at the
code it will complicate things because the point at where that plot-command
string is constructed it doesn't know much about the type of data it is
working with, it's just constructing and indexing expression.  That's down the
road.

For me, the multiple-floated variable_dock_widgets seems to work fine.  I do
see what you are saying about the floated windows not closing along with the
main V.E. window un-displaying.  That is strange, but I did check that the
parent hierarchy is complete (i.e., everyone has a parent), but it could be
that Qt is making the choice in this case.  There might be flag settings.  If
not, I'm sure it is a simple one or two line fix.

The focus isn't 100% perfect--I can see some issues here too.  When hiding and
re-opening the V.E. the floated window no longer has the blue highlight (even
though I can tell it still has the focus).  The question is should this be
addressed at the octave_dock_widget level or some added logic at the inherited
variable_dock_widget level.

So, I'd like to hold off perfecting the blue highlight and focus issues. 
First, the main goal here is to get back to the current status with the new
QMainWindow layout along with code cleanup, better reuse of code, etc.  Code
evolves so it is good to halt at a certain spot and let others digest things. 
Second, I'd like to get input from Torsten regarding focus and such because
where someone like me could spend five hours perfecting the focus, someone
else who's dealt with it already could see a more precise way of doing it in
fifteen minutes.  I know what I have right now for turning the blue background
on and off is close, so I don't want to go adding all sorts of complicated
logic that makes it difficult for someone else to debug.  I do know the fixes
shouldn't be more than a few lines.

Anyway, a new version is attached with all features restored.

(file #43338)
    _______________________________________________________

Additional Item Attachment:

File name: octave-multipanel_variable_editor-djs2018feb17.patch Size:98 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53046>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/