[Octave-bug-tracker] [bug #53275] Variable Editor: Undocking variable window causes it to become nearly full screen

[Dan Sebald]

Follow-up Comment #15, bug #53275 (project octave):

OK, this changeset is ready.

I like the look and the coding approach is fairly straightforward.  I added a
QFrame to the variable panels without it serving as a container but instead
handle sizing along with the variable_editor_widget resize event:


+    // Custom title bars cause loss of decorations, add a frame
+    m_frame = new QFrame (this);
+    m_frame->setFrameStyle (QFrame::Box | QFrame::Sunken);
+    m_frame->setAttribute (Qt::WA_TransparentForMouseEvents);



+  void variable_dock_widget::resizeEvent (QResizeEvent *)
+  {
+    if (m_frame)
+      m_frame->resize (size ());
+  }


I chose the sunken frame because I felt it a little more subtle as far as
delimiting subpanels.  The non-sunken line matched the table boundary which
gave the illusion of a very thick single line.  See attached screenshots.  At
first I was going to turn the QFrame off when in docked non-floating mode, but
then I sort of liked the appearance of the subtle frames.

I used resource_manager::icon() for the icons I added, but I left the close
button as is.  To use the close button in resource_manager::icon() would
require renaming those couple buttons in libgui/src/icons to match the
FreeDesktop naming convention.

Perhaps the fullscreen/restore icon choice could be different.  E.g., use the
same icon that is a '+' on my system, but I don't know what that would be
called.  Nonetheless, the appearance and behavior are now what I had imagined,
and I'll leave any further mods to Torsten.

(file #43487, file #43488, file #43489)
    _______________________________________________________

Additional Item Attachment:

File name: octave-ve_improved_fullscreen-djs2018mar07.patch Size:11 KB
File name: Box_Screenshot_from_2018-03-07_17-18-45.png Size:40 KB
File name: Box_Sunken_Screenshot_from_2018-03-07_17-21-20.png Size:35 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53275>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/