[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #53537] main_window::focus_changed() routine s

From: Dan Sebald
Subject: [Octave-bug-tracker] [bug #53537] main_window::focus_changed() routine should be improved
Date: Sun, 1 Apr 2018 22:44:07 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

Follow-up Comment #4, bug #53537 (project octave):

I'm attaching a changeset that simplifies the routine by leaving out code and
no real change in logic.  *There's still a bug*, which I will describe in a
follow-up post.

1) I find the outer loop that looks at next widget in focus change to be

2) The m_editor_window is a pointer to a file_editor_interface, and

namespace octave
  class file_editor_interface : public octave_dock_widget

so there is no need to cast m_editor_window.

3) I don't see what the second expression in (dock || m_active_dock !=
edit_dock_widget) adds, so removed it.  I can't think of a corner case, but
maybe there is one.

(file #43765)

Additional Item Attachment:

File name: octave-main_window_focus_change_cleanup-djs2018apr01.patch Size:3


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]