[Octave-bug-tracker] [bug #53650] build: clang-6.0 compiler warnings

[Mike Miller]

Follow-up Comment #3, bug #53650 (project octave):

Rik - the one I don't understand fully is the unused lambda capture warning,
which is about some code that you wrote last year in 206a7eb1561b.

Is there some performance reason for what you wrote


    const T zero = T ();

    return std::count_if (d, d + nel,
                          [zero] (T elem) { return elem != zero; });


instead of this


    return std::count_if (d, d + nel,
                          [] (T elem) { return elem != T (); });


I made that change as in the attached diff, but I'm not sure how to test it.
The octave_base_diag class doesn't use the DiagMatrix nnz specialization. No
functional changes, test suite runs fine.

(file #43930)
    _______________________________________________________

Additional Item Attachment:

File name: warnings.diff                  Size:0 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53650>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/