[Octave-bug-tracker] [bug #53276] GUI: undocked panes cannot be moved, or resized along upper border

[Dan Sebald]

Follow-up Comment #106, bug #53276 (project octave):

You mentioned the file editor.  This probably has to do with the change I made
to main-window.cc:


* main-window.cc (main_window::focus_changed): Simplify this routine by
  eliminating the indefinite loop search through all previous focus objects.
  Instead, just look for the currently focused object in all the octave dock
  widgets and if not found don't change the highlight.  Also drop the special
  handling for the editor.


Attached is a patch where I backed out the above change.  Give that a try.

I do feel though that the focus_changed routine is overly complicated with it
search through the previous focused object "linked list" that could result in
an infinite loop by happenstance so is arbitrarily limited to 100 counts or
something.  Anyway, the file editor is treated with special consideration.  I
took that out, and that may be why on your system there is a highlight issue
on the first try.  My feeling is that there should be a better way of having
the File Editor deal with it more locally, such as in some focusInEvent
virtual function override.

Yes, the items addressed in this patch have grown.  I never suspected so many
related bugs in KDE and Qt to arise.  I myself prefer more atomic changes, but
I really don't want to put too much more time in this changeset.  If anything,
I'd consider removing the recent bug addressed, i.e., everything contained
within


+// See  Octave bug #53807 and https://bugreports.qt.io/browse/QTBUG-44813
+#if (QT_VERSION >= 0x050302) && (QT_VERSION <= QTBUG_44813_FIX_VERSION)


into a separate patch at Bug #53807.  But the way that this has gone is folks
flag all these items as lumped into the one feature whether consciously or
not, i.e., "this or that is flaky on some platform, so the patch must be
wrong".  Where does one separate these?  If you want, read the commit message
summary and break things up.  But then we'll have five different bug reports
to repeat the process on.

The way I look at it, the patch addresses some major issues and restores full
Qt QDockWidget mousing features.  Any issues that remain are small, easy fixes
that can be dealt with in new bug reports as they arise.  The one exception is
KDE Oxygen--I can't see any sort of work-around for that.  So, given 4.4.0 was
just released and its the start of a new cycle, maybe it is better to do the
bulk change which gives beta-testers time to find issues.

(file #44078)
    _______________________________________________________

Additional Item Attachment:

File name: octave-float_as_toplevel-djs2018may03.patch Size:49 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?53276>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/