[Octave-bug-tracker] [bug #52800] The icon for dock widgets for *figure* windows needs improvement

[Dan Sebald]

Follow-up Comment #7, bug #52800 (project octave):

Ah, good point.  I don't see "setWindowIcon" in too many locations in the
source, so perhaps something is setting the icon back to the base icon.

The location that the "Figure" icon has be set is within the file
libgui/graphics/FigureWindow.cc:


  FigureWindow::FigureWindow (QWidget *xparent)
    : FigureWindowBase (xparent)
  {
    // set icon from application resources
    setWindowIcon (QIcon (":/actions/icons/logo.png"));
  }


Since the FigureWindow is not one of the main gui objects (i.e.,
octave_dock_widget) that code we've been discussing doesn't apply.  That's a
bit problematic in the sense that the above could be changed easily to set the
logo based on the settings (i.e., LETTER, GRAPHIC or NONE)--no problem.  But
then if the user changes the icon type in the settings, there needs to be some
additional code


  void main_window::notice_settings (const QSettings *settings)
  {}


that adjusts the icon in all open Figure windows.  That might be a bit more
challenging because I don't know where to look to in order to determine the
figure list.  The list might be embedded in core code, not the GUI
subdirectory.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?52800>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/