[Octave-bug-tracker] [bug #54237] 'abs' function template hack in pr-output.cc is not portable

[Mike Miller]

Update of bug #54237 (project octave):

                  Status:               Postponed => Patch Submitted        

    _______________________________________________________

Follow-up Comment #2:

The updated attached patch fixes both of these problems for me. I think this
is relatively simple and suitable for the stable branch.

* Clang unused function warning is solved by declaring overrides for the eight
intN_t and uintN_t types instead of the ten builtin int types.
* Solaris ambiguous overload resolution error is solved by renaming the
function from 'abs' to 'int_abs', seems stupid but without further information
this may be necessary on some operating systems / compilers.

These problems can certainly be separated and applied individually. If we
don't want to dumb our code down for the error on Solaris I would be fine with
keeping the name 'abs' for now and waiting for more information.

(file #44501)
    _______________________________________________________

Additional Item Attachment:

File name: bug54237.diff                  Size:4 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54237>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/