[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #53899] [octave forge] (io) Octave crashes whe
From: |
Philip Nienhuis |
Subject: |
[Octave-bug-tracker] [bug #53899] [octave forge] (io) Octave crashes when writing large dbf files with dbfwrite |
Date: |
Sun, 30 Sep 2018 07:38:08 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 SeaMonkey/2.48 |
Update of bug #53899 (project octave):
Item Group: Other => Segfault, Bus Error, etc.
Status: Ready For Test => In Progress
_______________________________________________________
Follow-up Comment #7:
Thanks for the patch Matthew, congrats with your PhD thesis.
Some preliminary questions & remarks about the patch:
1. Why is "fclose all" required? behind the users's back that may also close
other files that need to stay open.
2. Why does the .dbf file need to be opened specifically in ieee-le mode and
then add arch descriptors to every write stmt?
3. 2nd hunk, writing dates:
* AFAIU uint8 needs no ieee-le arch, it's just one byte.
* I suppose we'd need to subtract using ".-" rather than "-" to avoid
broadcasting (-risk);
* The next 4-byte sequences are just zero-filled placeholders, no need for
ieee-le either.
I'll look into the data writing part later.
At first sight the vectorizing trick looks neat! but I'm always wary for
overflow somewhere deep down, esp. in formatted I/O, so I'd rather break it up
into some proper (yet big) buffer size. A cumsum of fldlngs may come in handy
there.
Status => back into "In Progress"
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?53899>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/