[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graph

From: Pantxo Diribarne
Subject: [Octave-bug-tracker] [bug #42490] helpdlg does not return a proper graphics handle
Date: Fri, 5 Oct 2018 07:02:20 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0

Follow-up Comment #21, bug #42490 (project octave):

@Dan: In this case windows an Mac users would have no icon at all. The
fallback mechanism I used is the one that is already in place and works very
well for all other icons. Basically it uses QIcon::fromTheme [1] which only
works on linux platform.

I am pretty sure that Qt uses native icons on Windows and Mac when displaying
a QMessageBox so that fallback icon we will get on those platforms won't match
the one we'll get when an actual QMessageBox is displayed. Yes I could extract
the icon from a QMessageBox in case none is returned, but honestly I have
recently worked on a patch that I couldn't really test myself (since I didn't
have a Mac) and I don't want to do this again, not now. So I'd be in favor of
leaving this as is and wait for complaints if any. 

[1] http://doc.qt.io/qt-5/qicon.html#fromTheme


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]