[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #50820] [octave forge] (signal) pwelch incorre

From: STPR
Subject: [Octave-bug-tracker] [bug #50820] [octave forge] (signal) pwelch incorrectly discards DC component
Date: Tue, 9 Oct 2018 11:36:40 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0

Follow-up Comment #16, bug #50820 (project octave):

John: I noticed that as well, but for the time being I did not focus on
optimising existing code; just get all the features to work. If you are happy
with my changes to the code, pwelch now is completely compatible with MATLAB,
barring few tests. 

1) Yes, fft() pads zero as required and we really do not require that before
2) I was going to go for reshape as well initially, it was really a flip of a
coin for this one. I just needed something that worked.
3) I cannot think of any case where it would make sense to subtract 3.
Speaking of which, we should include a sanity check to make sure the specified
size or window vector does not exceed the signal size.
4) I am currently not sure how MATLAB enforces short vector size, I have to
test it out next time I am in the university. But on top of my head, I think
that there should at least be 3 elements for shifting/onesided PSD to work


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]