[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #54882] fail to build with Qt 4.8: class QPoin

From: Torsten
Subject: [Octave-bug-tracker] [bug #54882] fail to build with Qt 4.8: class QPointer<> has no member named 'clear'
Date: Wed, 24 Oct 2018 12:28:26 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0

Follow-up Comment #4, bug #54882 (project octave):

You are right, the current code (clear) does not destroy the octave_cmd
object. Obviously, I have misinterpreted the documentation. The following
simple patch fixes the issue and is backward compatible

diff -r e9c24b5e8673 libgui/src/octave-cmd.cc
--- a/libgui/src/octave-cmd.cc  Thu Oct 11 18:46:05 2018 +0200
+++ b/libgui/src/octave-cmd.cc  Wed Oct 24 13:37:40 2018 +0200
@@ -178,7 +178,7 @@ namespace octave
             cmd_gp->execute (interp);
-        cmd_gp.clear ();    // remove the original cmd pointer
+        delete cmd_gp;    // destroy the referred octave_cmd object
     if (repost)  // queue not empty, so repost event for further processing

I am going to prepare a changeset.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]