[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #54922] demo surfl 1 fails

From: Markus Mützel
Subject: [Octave-bug-tracker] [bug #54922] demo surfl 1 fails
Date: Wed, 31 Oct 2018 16:16:41 -0400 (EDT)
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Update of bug #54922 (project octave):

                  Status:               Confirmed => Patch Submitted        
        Operating System:               GNU/Linux => Any                    


Follow-up Comment #2:

Thanks Rik for pointing this to me.

With that change, we only calculate face or vertex normals "if they are
needed". That means, "facenormals" are calculated only for flat lighting and
only if a light object is present in the same axes. Similarly, "vertexnormals"
are calculated only for gouraud lighting and if a light object is present in
the same axes.
This was done to avoid calculating these properties when they aren't necessary
(could be costly if there were many faces and vertices). This is also what
Matlab seems to do.

The attached patch sets the "facelighting" property of the surface that is
created in surfl and temporarily adds a light object to its parent axes.

It also adds an "only" to the respective sentence in the "NEWS" file. Please
let me know if we should be any more wordy there. This might be a
compatibility consideration for existing user code as well.

Alternatively, we could always calculate the face and vertex normals (not only
if certain pre-conditions are met).

(file #45340)

Additional Item Attachment:

File name: bug54922_surfl_vertexnormals.patch Size:1 KB


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]