[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not vi
From: |
Pantxo Diribarne |
Subject: |
[Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible |
Date: |
Thu, 8 Nov 2018 03:23:39 -0500 (EST) |
User-agent: |
Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:62.0) Gecko/20100101 Firefox/62.0 |
Follow-up Comment #4, bug #54970 (project octave):
@Markus: you need to add a "u" to base_properties::visible, make
base_properties::update_visible virtual and overload it in patch::properties.
The following works for me:
diff -r 8195c04c596f libinterp/corefcn/graphics.in.h
--- a/libinterp/corefcn/graphics.in.h Thu Nov 08 09:05:24 2018 +0100
+++ b/libinterp/corefcn/graphics.in.h Thu Nov 08 09:20:26 2018 +0100
@@ -2378,7 +2378,7 @@
string_property type frs , ty
handle_property uicontextmenu u , graphics_handle ()
any_property userdata , Matrix ()
- bool_property visible , "on"
+ bool_property visible u , "on"
// Octave-specific properties
bool_property __modified__ hs , "on"
@@ -2387,6 +2387,8 @@
virtual void update_handlevisibility (void);
+ virtual void update_visible (void) { };
+
protected:
struct cmp_caseless_str
{
@@ -4893,6 +4895,7 @@
private:
std::string bad_data_msg;
+ void update_visible (void) { /* Do something */ };
void update_faces (void) { update_data ();}
void update_vertices (void) { update_data ();}
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?54970>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Guillaume, 2018/11/06
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Rik, 2018/11/06
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Guillaume, 2018/11/06
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Markus Mützel, 2018/11/08
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible,
Pantxo Diribarne <=
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Rik, 2018/11/08
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Markus Mützel, 2018/11/09
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Rik, 2018/11/10
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Guillaume, 2018/11/12
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Markus Mützel, 2018/11/12
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Guillaume, 2018/11/12
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Markus Mützel, 2018/11/12
- [Octave-bug-tracker] [bug #54970] Use of camlight when a patch is not visible, Guillaume, 2018/11/12