octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug fix for binary saving


From: Michael Goffioul
Subject: Bug fix for binary saving
Date: Mon, 18 Dec 2006 14:26:12 +0100
User-agent: Thunderbird 1.5.0.8 (Windows/20061025)

Using a signed char to load an octave binary file leads to a wrong detection
of the type flag: -1 instead of 255. The attached patch solves the problem.

Michael.

Index: src/ls-oct-binary.cc
===================================================================
RCS file: /cvs/octave/src/ls-oct-binary.cc,v
retrieving revision 1.10
diff -c -r1.10 ls-oct-binary.cc
*** src/ls-oct-binary.cc        23 May 2006 06:05:14 -0000      1.10
--- src/ls-oct-binary.cc        18 Dec 2006 13:24:16 -0000
***************
*** 139,145 ****
  {
    std::string retval;
  
!   char tmp = 0;
  
    int32_t name_len = 0;
    int32_t doc_len = 0;
--- 139,145 ----
  {
    std::string retval;
  
!   unsigned char tmp = 0;
  
    int32_t name_len = 0;
    int32_t doc_len = 0;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]