address@hidden: gcc 4.3 warnings]

[Rafael Laboissiere]

Below are changes to the Octave sources needed to make it compile with gcc
4.3.  These are actually problems with the ufsparse upstream headers.  Could
someone in the Debian SciComp Team take some action, please?

Thanks,

-- 
Rafael
> --- Begin Message ---
>
>
>
> Subject: 
>
> gcc 4.3 warnings
>
>
>
>
> Date: 
>
> Tue, 3 Apr 2007 22:36:44 -0400
>
>
>
>
> I made the following changes to avoid warnings like this from gcc 4.3:
>
>   liboctave/dSparse.cc:6056: warning: deprecated conversion from string 
> constant to 'char*'
>
> I'd rather avoid ugliness like this, so would someone like to work on
> making the ufsparse headers and functions const friendly and getting
> the necessary changes accepted upstream?  Or is it really possible
> that print_common might alter its char* argument?
>
> Thanks,
>
> jwe
>
> Index: liboctave/CSparse.cc
> ===================================================================
> RCS file: /cvs/octave/liboctave/CSparse.cc,v
> retrieving revision 1.32
> diff -u -u -r1.32 CSparse.cc
> --- liboctave/CSparse.cc        6 Dec 2006 20:19:14 -0000       1.32
> +++ liboctave/CSparse.cc        4 Apr 2007 02:35:06 -0000
> @@ -5828,7 +5828,8 @@
>               CHOLMOD_NAME(free_dense) (&X, cm);
>               CHOLMOD_NAME(free_factor) (&L, cm);
>               CHOLMOD_NAME(finish) (cm);
> -             CHOLMOD_NAME(print_common) (" ", cm);
> +             static char tmp[] = " ";
> +             CHOLMOD_NAME(print_common) (tmp, cm);
>               END_INTERRUPT_IMMEDIATELY_IN_FOREIGN_CODE;
>             }
>  #else
> @@ -6104,7 +6105,8 @@
>               CHOLMOD_NAME(free_sparse) (&X, cm);
>               CHOLMOD_NAME(free_factor) (&L, cm);
>               CHOLMOD_NAME(finish) (cm);
> -             CHOLMOD_NAME(print_common) (" ", cm);
> +             static char tmp[] = " ";
> +             CHOLMOD_NAME(print_common) (tmp, cm);
>               END_INTERRUPT_IMMEDIATELY_IN_FOREIGN_CODE;
>             }
>  #else
> @@ -6396,7 +6398,8 @@
>               CHOLMOD_NAME(free_dense) (&X, cm);
>               CHOLMOD_NAME(free_factor) (&L, cm);
>               CHOLMOD_NAME(finish) (cm);
> -             CHOLMOD_NAME(print_common) (" ", cm);
> +             static char tmp[] = " ";
> +             CHOLMOD_NAME(print_common) (tmp, cm);
>               END_INTERRUPT_IMMEDIATELY_IN_FOREIGN_CODE;
>             }
>  #else
> @@ -6651,7 +6654,8 @@
>               CHOLMOD_NAME(free_sparse) (&X, cm);
>               CHOLMOD_NAME(free_factor) (&L, cm);
>               CHOLMOD_NAME(finish) (cm);
> -             CHOLMOD_NAME(print_common) (" ", cm);
> +             static char tmp[] = " ";
> +             CHOLMOD_NAME(print_common) (tmp, cm);
>               END_INTERRUPT_IMMEDIATELY_IN_FOREIGN_CODE;
>             }
>  #else
> Index: liboctave/dSparse.cc
> ===================================================================
> RCS file: /cvs/octave/liboctave/dSparse.cc,v
> retrieving revision 1.31
> diff -u -u -r1.31 dSparse.cc
> --- liboctave/dSparse.cc        16 Jan 2007 07:03:51 -0000      1.31
> +++ liboctave/dSparse.cc        4 Apr 2007 02:35:08 -0000
> @@ -6053,7 +6053,8 @@
>               CHOLMOD_NAME(free_dense) (&X, cm);
>               CHOLMOD_NAME(free_factor) (&L, cm);
>               CHOLMOD_NAME(finish) (cm);
> -             CHOLMOD_NAME(print_common) (" ", cm);
> +             static char tmp[] = " ";
> +             CHOLMOD_NAME(print_common) (tmp, cm);
>               END_INTERRUPT_IMMEDIATELY_IN_FOREIGN_CODE;
>             }
>  #else
> @@ -6300,7 +6301,8 @@
>               CHOLMOD_NAME(free_sparse) (&X, cm);
>               CHOLMOD_NAME(free_factor) (&L, cm);
>               CHOLMOD_NAME(finish) (cm);
> -             CHOLMOD_NAME(print_common) (" ", cm);
> +             static char tmp[] = " ";
> +             CHOLMOD_NAME(print_common) (tmp, cm);
>               END_INTERRUPT_IMMEDIATELY_IN_FOREIGN_CODE;
>             }
>  #else
> @@ -6564,7 +6566,8 @@
>               CHOLMOD_NAME(free_dense) (&X, cm);
>               CHOLMOD_NAME(free_factor) (&L, cm);
>               CHOLMOD_NAME(finish) (cm);
> -             CHOLMOD_NAME(print_common) (" ", cm);
> +             static char tmp[] = " ";
> +             CHOLMOD_NAME(print_common) (tmp, cm);
>               END_INTERRUPT_IMMEDIATELY_IN_FOREIGN_CODE;
>             }
>  #else
> @@ -6831,7 +6834,8 @@
>               CHOLMOD_NAME(free_sparse) (&X, cm);
>               CHOLMOD_NAME(free_factor) (&L, cm);
>               CHOLMOD_NAME(finish) (cm);
> -             CHOLMOD_NAME(print_common) (" ", cm);
> +             static char tmp[] = " ";
> +             CHOLMOD_NAME(print_common) (tmp, cm);
>               END_INTERRUPT_IMMEDIATELY_IN_FOREIGN_CODE;
>             }
>  #else
>
> --- End Message ---