[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patch to hist for changes in bar
From: |
John W. Eaton |
Subject: |
Re: Patch to hist for changes in bar |
Date: |
Thu, 26 Apr 2007 12:27:03 -0400 |
On 26-Apr-2007, David Bateman wrote:
| John W. Eaton wrote:
| > On 25-Apr-2007, David Bateman wrote:
| >
| > | The default bar width in hist is 0.8 and so the bars don't touch. The
| > | old behavior of hist was that the bar width of 1.0 should be used. The
| > | 1.0 is the width of the bar.. Compare "bar(1:10,1:10)" against
| > | "bar(1:10,1:10,1.0)". It looks like the error you are seeing is in fact
| > | due to a small error in __bar__.m in that non string arguments or cell
| > | arrays should not be passed to __pltopt__. There was also an issue with
| > | the previous patch as hist(randn(1e6,1)) for example returned the figure
| > | handle even if nargout was zero.
| >
| > OK. Please check this in.
| >
| > You might also change
| >
| > | else
| > | ! if (nargout == 1)
| > | ! nn = bar (x, freq, 1.0);
| > | ! else
| > | ! bar (x, freq, 1.0);
| > | ! endif
| > | endif
| >
| > to be just
| >
| > elseif (nargout == 1)
| > ..
| > else
| > ..
| > endif
| >
| > Thanks,
| >
|
| Done..
I'm seeng two failures in the hist tests now:
>>>>> processing /export/home/jwe/src/octave/scripts/plot/hist.m
***** assert(hist(1,1),1);
!!!!! test failed
error: invalid vector index = 0
***** test
for n = [10, 30, 100, 1000]
assert( sum(hist([1:n], n)), n );
assert( sum(hist([1:n], [2:n-1])), n);
assert( sum(hist([1:n], [1:n])), n );
assert( sum(hist([1:n], 29)), n);
assert( sum(hist([1:n], 30)), n);
endfor
!!!!! test failed
error: assert (sum (hist ([1:n], n)),n) expected
10
but got
-2
values do not match
jwe
- Patch to hist for changes in bar, David Bateman, 2007/04/25
- Patch to hist for changes in bar, John W. Eaton, 2007/04/25
- Re: Patch to hist for changes in bar, David Bateman, 2007/04/25
- Re: Patch to hist for changes in bar, John W. Eaton, 2007/04/25
- Re: Patch to hist for changes in bar, David Bateman, 2007/04/25
- Re: Patch to hist for changes in bar,
John W. Eaton <=
- Re: Patch to hist for changes in bar, David Bateman, 2007/04/26
- Re: Patch to hist for changes in bar, John W. Eaton, 2007/04/26
- Re: Patch to hist for changes in bar, David Bateman, 2007/04/26