[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: wrong use of color_property in patch.facecolor
From: |
David Bateman |
Subject: |
Re: wrong use of color_property in patch.facecolor |
Date: |
Sun, 30 Sep 2007 17:06:19 +0200 |
User-agent: |
Thunderbird 1.5.0.7 (X11/20060921) |
Shai Ayal wrote:
> Hi
>
> I noticed a wrong use for setting the color property. It relates to
> the problems we discussed on setting radio_value based properties.
>
> the property is patch.facecolor. The way it should have been
> implemented is using the attached patch. Note that this way avoids the
> duplication of the allowed radio_values both in
> patch::properties::properties and in patch::properties::set by using
> the "a" modifier in the property declaration
>
> It also eliminates the need to change
> color_property::color_property(const octave_value&).
>
> Shai
>
> 2007-09-29 Shai Ayal <address@hidden>
>
> * graphics.cc ((color_property::color_property (const
> octave_value& val)): Undo change from 2007-09-26
> (patch::properties::properties): use the "a" modifier to
> face_color & edge_color properties
> (patch::properties::set): Undo change from 2007-09-26
> * graphics.h.in (color_property::color_property
> (const octave_value& val)): Undo change from 2007-09-26
Shai,
I made this change and the reason is that if you can't pass the
radio_value to color_property then there is no way to do something like
set (h, "facecolor", "interp")
Will this change keep that functionality?
D.