[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Allow installation of extracted packages with pkg.m
From: |
Thomas Weber |
Subject: |
Re: Allow installation of extracted packages with pkg.m |
Date: |
Sun, 23 Mar 2008 22:02:01 +0100 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
On 23/03/08 11:49 -0400, John W. Eaton wrote:
> On 9-Mar-2008, Thomas Weber wrote:
> | # HG changeset patch
> | # User Thomas Weber <address@hidden>
> | # Date 1205090922 -3600
> | # Node ID e12d15c8beb3d1de9b166c6957a84fd82b989a7e
> | # Parent 85da2ab0c6fd626a891fdcb9185ba2d80f96ca0e
> | pkg.m accepts extracted packages for installation
> |
> | diff -r 85da2ab0c6fd -r e12d15c8beb3 scripts/ChangeLog
> | --- a/scripts/ChangeLog Fri Mar 07 20:17:54 2008 -0500
> | +++ b/scripts/ChangeLog Sun Mar 09 20:28:42 2008 +0100
> | @@ -1,3 +1,7 @@ 2008-03-07 John W. Eaton <address@hidden
> | +2008-03-09 Thomas Weber <address@hidden>
> | +
> | + * pkg/pkg.m: Accepts already extracted packages for installation.
> | +
> | 2008-03-07 John W. Eaton <address@hidden>
> |
> | * plot/contourf.m: Set axes layer property to "top".
> | diff -r 85da2ab0c6fd -r e12d15c8beb3 scripts/pkg/pkg.m
> | --- a/scripts/pkg/pkg.m Fri Mar 07 20:17:54 2008 -0500
> | +++ b/scripts/pkg/pkg.m Sun Mar 09 20:28:42 2008 +0100
> | @@ -599,10 +599,23 @@ function install (files, handle_deps, au
> | if (length (dirlist) > 3)
> | error ("bundles of packages are not allowed")
> | endif
> | + endif
>
> Why are you adding this endif? It seems it would not match anything.
It corresponds to
if (exist (tgz, "file"))
at line 575. I need to break out of it, as "tgz" is a directory in this
case.
> I don't know pkg.m very well, so it would help me if someone who does
> could comment on this patch. If the above is generally OK and the
> loop is not needed, then please resubmit the patch with the loop
> removed. Also please explain the apparently stray "endif".
Well, I asked about the loop, so someone else should comment. The
"endif" is explained above.
Thomas