octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Locking graphics system - GUI/octave synchronization


From: John W. Eaton
Subject: Re: Locking graphics system - GUI/octave synchronization
Date: Sun, 20 Jul 2008 10:18:43 -0400

On 20-Jul-2008, Michael Goffioul wrote:

| Wouldn't be enough to just initialize both rep and count to 0 in
| the protected constructor?

They are in a union, right?  So wouldn't you actually need to
initialize the one that would be used?  In any case, I would prefer to
avoid this style in the future since I think the other method is
easier to understand and there won't be any confusion over how the
values in the union are supposed to be used.

| I used it, because it avoided me to define 2 classes.

We still have the same number of classes defined.  Before it was
octave_mutex, octave_default_mutex and the system dependent classes.
Now it is octave_mutex, octave_base_mutex (I just changed the name to
empasize that it is the base class for the others) and the system
dependent classes.

| Note that I used the same design for gh_manager::event_data,
| so the initialization should be adapted.

Then I think that one should also be changed to use the same style as
we are using in the octave_value class.

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]