octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: make check for octave 3.0.2 for cygwin


From: Tatsuro MATSUOKA
Subject: Re: make check for octave 3.0.2 for cygwin
Date: Thu, 21 Aug 2008 14:48:31 +0900 (JST)

Hello

The changeset I sent in the previous mail is incorrect
Please use the below.

diff -r 4908e39553b0 ChangeLog
--- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400
+++ b/ChangeLog Thu Aug 21 14:47:35 2008 +0900
@@ -1,3 +1,7 @@
+2008-08-21    Tatsuro MATSUOKA  <address@hidden>
+
+       parse and tolerance errors of the previous patch is corrected
+
 2008-08-19  Jaroslav Hajek <address@hidden>
 
        Version 3.0.2 released.
diff -r 4908e39553b0 src/DLD-FUNCTIONS/rand.cc
--- a/src/DLD-FUNCTIONS/rand.cc Tue Aug 19 16:15:52 2008 -0400
+++ b/src/DLD-FUNCTIONS/rand.cc Thu Aug 21 14:47:35 2008 +0900
@@ -950,7 +950,7 @@
 %!test
 %! % Test fixed state
 %! randp("seed",1);
-%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e-6))
+%! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
999981440],1e2)
 %!test
 %! if (__random_statistical_tests__)
 %!   % statistical tests may fail occasionally.


Regards

Tatsuro


--- Tatsuro MATSUOKA <address@hidden> wrote:

> Hello
> 
> > http://tw-math.de/~highegg/releases/
> I have just built on cygwin 
> 
> 
> The changeset I sent before for rand.cc was incorrect.
> It includes parse error
> %! assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
> 999981440],1e-6))
> 1e-6)) should be 1e-6)
> 
> However, this addition of tolelarance is not proper because it is not 
> relative torelance but
> abosolute
> tolelace 
>  randp("seed",1);
>  assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
> 999981440],1e2)
> !!!!! test failed
> error: assert (randp (1e9, 1, 6),[1000006208, 1000012224, 999981120, 
> 999963520, 999963072,
> 999981440],1e-6) expected
>    1.0000e+09   1.0000e+09   9.9998e+08   9.9996e+08   9.9996e+08   9.9998e+08
> but got
>    1.0000e+09   1.0000e+09   9.9998e+08   9.9996e+08   9.9996e+08   9.9998e+08
> maximum absolute error 27 exceeds tolerance 1e-06
> shared variables {
>   __random_statistical_tests__ = 0
> }
> 
> This can be confirmed
> 
> octave:6> randp("seed",1);
> octave:7> randp(1e9,1,6)-[1000006208 1000012224 999981120 999963520 999963072 
> 999981440]
> ans =
> 
>    17   27  -20   18  -19   -8
> 
> 
> *********
> So that
> It should be 
>  assert(randp(1e9,1,6),[1000006208 1000012224 999981120 999963520 999963072 
> 999981440],1e2)
> as test suggested.
> 
> This error is trivial so that it would be corrected in the next release.
> 
> ******
> --- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400
> +++ b/ChangeLog Thu Aug 21 14:02:18 2008 +0900
> @@ -1,3 +1,7 @@
> +2008-08-21    Tatsuro MATSUOKA  <address@hidden>
> +
> +       parse and tolerance errors of the previous patch is corrected
> +
>  2008-08-19  Jaroslav Hajek <address@hidden>
>  
>         Version 3.0.2 released.
> diff -r 4908e39553b0 src/DLD-FUNCTIONS/rand.cc
> --- a/src/DLD-FUNCTIONS/rand.cc Tue Aug 19 16:15:52 2008 -0400
> +++ b/src/DLD-FUNCTIONS/rand.cc Thu Aug 21 14:02:18 2008 +0900
> @@ -937,7 +937,7 @@
>  %!test
>  %! % Test fixed state
>  %! randp("state",1);
> -%! assert(randp(1e9,1,6),[999915677 999976657 1000047684 1000019035 
> 999985749 999977692],1e-6)
> +%! assert(randp(1e9,1,6),[999915677 999976657 1000047684 1000019035 
> 999985749 999977692],1e2)
> 
> 
> 
> 
> --- Jaroslav Hajek <address@hidden> wrote:
> 
> > Hi,
> > 
> > the new tarballs are at
> > http://tw-math.de/~highegg/releases/
> > 
> > Since testing has already been done, I'd say the release is ready.
> > John, can you please upload them to the public places?
> > 
> > 
> > -- 
> > RNDr. Jaroslav Hajek
> > computing expert
> > Aeronautical Research and Test Institute (VZLU)
> > Prague, Czech Republic
> > url: www.highegg.matfyz.cz
> > 
> 
> 
> 
> --------------------------------------
> For All Sports Lovers! SPORTS OHEN PROJECT 2008
> http://pr.mail.yahoo.co.jp/yells/
> 


--------------------------------------
For All Sports Lovers! SPORTS OHEN PROJECT 2008
http://pr.mail.yahoo.co.jp/yells/


reply via email to

[Prev in Thread] Current Thread [Next in Thread]