octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[changeset] - x,y,zlabel/title respect axes font properties


From: John W. Eaton
Subject: [changeset] - x,y,zlabel/title respect axes font properties
Date: Thu, 09 Oct 2008 10:38:40 -0400

On  9-Oct-2008, John W. Eaton wrote:

| On  9-Oct-2008, John W. Eaton wrote:
| 
| | On  9-Oct-2008, Ben Abbott wrote:
| | 
| | | This changeset sets the font properties for the xlabel, ylabel,  
| | | zlabel, and title in a manner consistent with Matlab.
| | | 
| | | Meaning as new axis labels are set via xlabel(), ylabel(), zlabel(),  
| | | title() their font properties default to that of their parent axis.
| | 
| | | -
| | | -    h = __go_text__ (ca, "string", txt, "rotation", rot, varargin{:});
| | | +    h = __go_text__ (ca, "fontangle", get (gca, "fontangle"),
| | | +                         "fontname", get (gca, "fontname"),
| | | +                         "fontsize", get (gca, "fontsize"),
| | | +                         "fontunits", get (gca, "fontunits"),
| | | +                         "fontweight", get (gca, "fontweight"),
| | | +                         "string", txt, "rotation", rot, varargin{:});
| | 
| | If you are inheriting from the parent axes object, then shouldn't you
| | get the properties from CA instead of GCA()?
| 
| Oops.  Never mind.  I should have actually looked at the function
| before firing off the email.  In any case, since CA is already set to
| GCA() earlier in this function, it makese sense to use CA to avoid
| multiple calls to GCA().
| 
| I applied the changeset with this additional change.

OK, one more question (sorry for not being completely awake yet).

Now I'm wondering why this patch is even needed.  Shouldn't all
objects inherit all appropriate properties from their parents?  If so,
then the axis_label function seems liek the wrong place to do this,
and it seems bad that we would have to enumerate the properties that
are inherited instead of just having this happen automatically at some
lower level, when the text object is created.

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]