octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for OOP example.


From: Robert T. Short
Subject: Re: Patch for OOP example.
Date: Tue, 02 Jun 2009 06:15:51 -0700
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16


Cool.  Thanks.

Examples should be simple and easy to follow, not perfectly designed code!  Extensive error checking (etc.) often takes away from the message you are trying to convey.

Bob


Jaroslav Hajek wrote:
On Mon, Jun 1, 2009 at 7:10 PM, Robert T. Short
<address@hidden> wrote:
  
Jaroslav & John,

I can easily resubmit this patch later if it is a pain to deal with.  The
changes I made won't impact anything outside of the one example suite.
Examples with errors are kind of a bummer, but no major problem.

Bob

    

I applied the patch to the release-3-2-x repository.
I noticed that a few methods (subsasgn, subsref) still didn't work or
worked differently than mentioned in the docs.
In particular, I updated subsasgn and subsref to handle the full index
chain, i.e. stuff like
a.poly(1:2) = [3,4]
will work correctly.
I added a notice about this to the docs. I also changed the {}
semantics so that a{i} means the coefficient of x^i, as the
documentation says. a(i) = x gripes (makes no sense).
There's still room for more error checks and improvements (such as
stripping leading zeros after assignments), but I hope the examples
need not be perfect.

cheers

  


reply via email to

[Prev in Thread] Current Thread [Next in Thread]