octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: glob on Windows systems


From: Benjamin Lindner
Subject: Re: glob on Windows systems
Date: Sat, 16 Jan 2010 23:09:45 +0100
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)

John W. Eaton wrote:
On 11-Jan-2010, John W. Eaton wrote:

|   glob: does not work properly with backslash directory separator

Instead of modifying the gnulib glob function to handle \\ in
filenames, I propose the following patch for Octave.  Could someone
who is building on MinGW or with MSVC try this patch and let me know
whether it works?  If it does and there are no objections to this
solution, I'll apply the changeset.


There is a stray 'p' in your changeset

--- gnulib-glob.patch   Sat Jan 16 23:06:08 2010
+++ .hg/patches/gnulib-glob.patch       Sat Jan 16 22:54:38 2010
@@ -37,7 +40,7 @@
 +  && ! defined (OCTAVE_HAVE_POSIX_FILESYSTEM)
 +          std::replace_if (xpat.begin (), xpat.end (),
 +                           std::bind2nd (std::equal_to<char> (), '\\'),
-+                           '/')p;
++                           '/');
 +#endif
 +
          int err = ::glob (xpat.c_str (), GLOB_NOSORT, 0, &glob_info);

otherwise it works fine.
It also re-enables the tests when executing "make check".
Without it, no tests are run, because globbing does not return any
.m and .cc files...

benjamin


reply via email to

[Prev in Thread] Current Thread [Next in Thread]