octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warnings originating in gl2ps -- update


From: CdeMills
Subject: Re: warnings originating in gl2ps -- update
Date: Fri, 11 Feb 2011 03:11:45 -0800 (PST)


CdeMills wrote:
> 
> Enclosed. I tried 'hg export', but the patches are only between
> release-3-4-x and tip. I produced the patches with 'hg diff'. Seven files
> touched, including the Changelog. All warnings gone.
> 

Sorry, the fix in util.cc was wrong. Strangelly,
 if (nchars > -1 && size - nchars > 0)
makes around half of the tests to fail!

The right fix is to keep
   if (nchars > -1 && nchars < size)
and declare size as a ssize_t instead of a size_t. With this change, there
aren't any test failures.

Regards

Pascal
http://octave.1599824.n4.nabble.com/file/n3301114/sign-fix.pat sign-fix.pat 
-- 
View this message in context: 
http://octave.1599824.n4.nabble.com/warnings-originating-in-gl2ps-update-tp3298345p3301114.html
Sent from the Octave - Maintainers mailing list archive at Nabble.com.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]