Re: Bug #32319

[Michael D Godfrey]

On 02/14/2011 04:48 PM, Ben Abbott wrote:

On Feb 14, 2011, at 3:14 PM, Michael D Godfrey wrote:

> -------- Original Message --------
> Subject:	Re: Bug #32319
> Date:	Sun, 13 Feb 2011 22:27:27 +0100
> From:	logari81 <address@hidden>
> To:	Michael D Godfrey <address@hidden>
> CC:	octave maintainers mailing list <address@hidden>
> 
> On Sun, 2011-02-13 at 13:11 -0800, Michael D Godfrey wrote:

> > Hi,
> > 
> > Do you want to push the changeset for this bug (your bug32319-1b.diff
> > plus the Changelog entry)?
> > 
> > Does it make sense to close this report and open a new one about
> > plots not being refreshed, which I mentioned in my last comment on
> > 32319?  Or,  do you already know why that is happening?
> > 
> > Michael
> > 

> 
> hmm, I think we'd better wait for jwe's opinion about the patch. Maybe
> he prefers to fix this bug making correct use of waitpid.
> 
> In any case I don't have any explanation about the refresh problem yet,
> but it would probably be easy to fix if I would have a way to reproduce
> it.
> 
> Kostas
> 
> The patch referred to works correctly for me.  It fixes
> the fdopen error problem in fltk backend.  I noticed
> that it has been "waiting" long enough so that its lines
> numbers not longer match the current source.
> 
> Is it OK for Kostas to push an updated version?
> 
> Michael

I have no objection.

Ben

Kostas,

I am sure it is OK to push this.  Unfortunately, the patch
will need to be adjusted to the current files.  None of
the line numbers match anymore, and you need to add
a Changelog entry, of course.

Please go ahead and push this patch.

Michael