Re: Thread-safety issues in QtHandles

[Michael Goffioul]

On Mon, Nov 7, 2011 at 7:34 PM, John W. Eaton <address@hidden> wrote:
> OK, I tried the allocator patch and your changeset and did some
> timings.
>
> First, with neither patch applied, or with just the allocator patch, I
> get about 61 seconds to run the tests (cd to the tests directory in my
> build tree and run them directly with /usr/bin/time ../run-octave ...).
>
> After applying your patch in addition to the allocator patch, I get
> about 76 seconds.  That's a hefty performance penalty.
>
> I used the default build flags in all cases, so I have -O2
> in CXXFLAGS so I don't think this problem is due to not inlining
> functions.

Clearly, there's a performance penalty, as using shared_ptr is heavier
than simply count++. OTOH, the gain - thread-safety - is also non
negligible.

Michael.