octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cleaning up pkg.m


From: c.
Subject: Re: cleaning up pkg.m
Date: Thu, 15 Mar 2012 11:45:32 +0100

On 14 Mar 2012, at 18:50, Rik wrote:
> 
> I spent a lot of time improving the performance and functionality of the 
> string functions between 3.4.3 and 3.6.0.  I think you should be able to find 
> replacements.  Also, pkg.m is not something called in a     tight inner loop 
> so if you just want to use regexp to do your work that would be fine.
> 
> You would need to verify but the following look like replacements
> strip => strtrim
> rstrip => deblank
> split_by => strtrim (strsplit ())

Here is a changeset implementing these modifications.
Any objections if I push it?

c.

Attachment: open_oul4tYxV.txt
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]