The conv2 mess

[Jordi Gutiérrez Hermoso]

Can anyone understand wtf is going on in liboctave/oct-convn.cc ? Specifically,

    - wtf is an inner or an outer convolution?

    - wtf are the variables passed to convolve_nd? What is "acd" and
      "bcd"?

    - htf is an n-dimensional convolution computed recursively? I
      understand the 2d case is a base case, but how are the
      higher-dimensional cases done?

    - wtf is part of this written as Fortran functions? Is 6 Fortran
      copy-pasted files better than one C++ template?

    - wtf was this rewritten completely, and if it was, why does it
      still have Andy Adler's copyright statement, if it has none
      of his code in place, except one cargo-culted Shape enum?

    - Even with the attached patch, wtf are A and B only approximately
      equal?

      x = rand(100);
      y = ones(5);
      A = conv2(x,y)(5:end-4,5:end-4);
      B = conv2(x,y,"valid");

This code's wpm is too high:

    http://www.osnews.com/images/comics/wtfm.jpg

So htf do we fix this?

- Jordi G. H.

conv2-fix.diff
Description: Text Data