octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: warnin about 'info' is a bug in eigs-base.cc


From: John W. Eaton
Subject: Re: warnin about 'info' is a bug in eigs-base.cc
Date: Thu, 30 Aug 2012 10:22:26 -0400

On 30-Aug-2012, Jordi GutiƩrrez Hermoso wrote:

| I guessssss that I shooooouuld instead refactor and untangle the
| sparse code. Do you insist I do that? It seems like a stupid
| refactoring effort, but I guess we'll have to do it sooner or later.

I was initially very confused about what was going on with the double
use of info.  At the very least, I think that tricky code like that
deserves a comment to explain it.

I'm not insisting that you completely refactor and fix up that code.
But I would rather have a "force" argument for the SparseCHOL
constructor, and to not overload info for this purpose.  I'd also
prefer to avoid having using "nargout" in liboctave functions, as that
is not really a concept that applies there.  If you don't want to do
it, I will.

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]