Re: Tracking bug #38128 / Overloaded vertcat() not called in some cases

[Julien Bect]

Julien Bect wrote
> 
> Julien Bect wrote
>> I have uploaded a patch, which implements this idea (i.e., removes
>> dimension consistency checking when any_class is true) :
>> 
>> https://savannah.gnu.org/patch/?7935
>> 
>> This seems to fix the vertcat/horzcat problem. Note that I haven't been
>> able to run a full "make check", though (it segfaults when I reach the
>> tests for dblquad.m, but this is not related to my patch).
> I have now been able to run a full "make check" on a fresh new build
> without Java interface (see: 
> this thread
> <http://octave.1599824.n4.nabble.com/Segfault-when-running-quot-make-check-quot-td4649275.html>
>   
> ). Everything seems ok.

I just noticed that a few tests concerning classes and concatenation are
located test/class-concat (added by JWE in Nov 2011).

In patch #7935 (https://savannah.gnu.org/patch/?7935), I have added my own
tests in test/classes/test_classes.m.

Should I move my concatenation tests into test/class-concat, or rather merge
the old tests from test/class-concat into test/classes/test_classes.m ?

Julien.




--
View this message in context: 
http://octave.1599824.n4.nabble.com/Tracking-bug-38128-Overloaded-vertcat-not-called-in-some-cases-tp4649193p4649586.html
Sent from the Octave - Maintainers mailing list archive at Nabble.com.