Re: GUI won't build with older QScintilla

[Jordi Gutiérrez Hermoso]

On 5 April 2013 15:04, Torsten <address@hidden> wrote:
> On 04.04.2013 18:20, Jordi Gutiérrez Hermoso wrote:
>> I just tried today to build at 16431:1766d8655006, and got
>>
>>     In file included from
>>     /oct-src/libgui/src/m-editor/file-editor-tab.cc:32:
>>
>>     /oct-src/libgui/src/m-editor/lexer-octave-gui.h:29:34: error:
>>     Qsci/qscilexeroctave.h: No such file or directory
>>
>>     In file included from
>>     /oct-src/libgui/src/m-editor/file-editor-tab.cc:32:
>>
>>     /oct-src/libgui/src/m-editor/lexer-octave-gui.h:33: error:
>>     expected class-name before '{' token
>>
>>     /oct-src/libgui/src/m-editor/file-editor-tab.cc: In member
>>     function 'void file_editor_tab::update_lexer()':
>>
>>     /oct-src/libgui/src/m-editor/file-editor-tab.cc:215: error: cannot
>>     convert 'lexer_octave_gui*' to 'QsciLexer*' in assignment
>>
>>     /oct-src/libgui/src/m-editor/file-editor-tab.cc: In member
>>     function 'void file_editor_tab::center_current_line()':
>>
>>     /oct-src/libgui/src/m-editor/file-editor-tab.cc:1169: error:
>>     'class QsciScintilla' has no member named 'setFirstVisibleLine'
>>
>> All of these seem to be related to my older version of QScintilla
>> (2.4). The cset that seems to have introduced at least part of the new
>> QScintilla features is
>>
>>     changeset:   16403:7fa90eb41240
>>     user:        Torsten <address@hidden>
>>     date:        Sun Mar 31 23:56:11 2013 +0200
>>     summary:     gui: individually configurable styles of the editor
>>                  lexers
>>
>> More autoconf tests to check for QScintilla features, then?
>
> Jordi, could you please test the attached patch?

It fails here:

    
/home/jordi/coding/vcs/octave-devel/libgui/src/m-editor/file-editor-tab.cc:1167:
error:
    ‘SCI_SETFIRSTVISIBLELINE’ is not a member of ‘QsciScintillaBase’

However, are you sure you like the overall direction of this patch?
I'm not opposed to using newer features of QScintilla, and you don't
need to duplicate the QsciLexerOctave class in Octave. The
duplication, if that's what it is, seems very small, so perhaps it's
ok.

- Jordi G. H.