Re: GUI won't build with older QScintilla

[Jordi Gutiérrez Hermoso]

On 6 April 2013 04:35, Torsten <address@hidden> wrote:
> On 05.04.2013 22:18, John W. Eaton wrote:
>> On 04/05/2013 03:58 PM, Jordi Gutiérrez Hermoso wrote:
>>
>>> However, are you sure you like the overall direction of this
>>> patch? I'm not opposed to using newer features of QScintilla, and
>>> you don't need to duplicate the QsciLexerOctave class in Octave.
>>> The duplication, if that's what it is, seems very small, so
>>> perhaps it's ok.
>>
>> It would be OK to make it so that the feature is just not available
>> unless you have a newer version of QScintilla. I think that would
>> be better than trying to duplicate the missing feature.
>>
>
> It is not really a duplicate but just configuring the general
> Qscintilla-lexer-interface to work like the octave lexer.

Alright. I thought it was a little ugly to avoid using
QSciLexerOctave, but I don't know this part of the code well.

> We already have a check for version 2.6 in
> OCTAVE_CHECK_FUNC_FINDFIRST_MODERN. I am not sure whether another
> test should be added or if that existent test could be used
> (unnecessarily disabling the feature for versions between 2.5 and
> 2.6).

Adding another test makes more sense to me.

Let me know if you have an updated patch you'd like me to test.

Thanks,
- Jordi G. H.