|
From: | Daniel J Sebald |
Subject: | Re: Detaching from terminal and keyboard input for GUI |
Date: | Tue, 14 May 2013 00:23:40 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Thunderbird/3.1.16 |
On 05/13/2013 11:56 PM, Torsten wrote:
On 14.05.2013 04:44, Daniel J Sebald wrote:I can look at disabling this feature if Qsci/qscilexeroctave is not present. But I'm not really interested in duplicating this functionality in Octave in the even that it is not present in QScintilla. jweRe-implementing it is a bad idea. There is then two different versions, one from the QSci repository and one possibly from Octave repository. Too confusing for users and when users report problems. It would be better for someone to work with the QSci developers to keep that file up to date (or ask them to drop it and then maintain one as part of Octave project).I have no objections to the use of qscilexeroctave but just to clarify: The previously used lexer_octave_gui class was not a reimplementation of Qscintilla's octave lexer. The class was just a stub with functions for the default fonts, default colors, the keyword list and a function (lexer()) that selects the underlying (Q)Scintilla octave lexer. This avoids compilation errors with older versions of Qscintilla missing the octave lexer.
Well, ostensibly it serves the same purpose. The inherited class: http://code.google.com/p/openshapefactory/source/browse/Libs/QScintilla-gpl-2.5.1/Qt4/qscilexermatlab.cpp?r=eb84e57b18a318b3aa65588c66c92fca5cf71641does pretty much what you described. The Octave lexer class only adds a few more variable names.
It's worth thinking about. The logical thing is to use qscilexeroctave.cpp and coordinate its maintenance with QSci developers. (How often will it change?) But I wonder how many programmers utilize qscilexeroctave.cpp other than us? The reason is that programmers for some other app (not Octave) who choose the lexer based upon file extension ".m" are more apt to use the base class qscilexermatlab.cpp. Perhaps if they programmed things so that the lexer were selectable there might be an option for picking Octave. Anyone know how qscilexeroctave.cpp made it into QSci? Did someone from Octave project make a request? Or did someone from some other project make a request?
Dan
[Prev in Thread] | Current Thread | [Next in Thread] |