Re: build failure on [2013-05-15 Wed]

[Ben Abbott]

On May 16, 2013, at 1:38 PM, Daniel J Sebald wrote:

> On 05/16/2013 12:22 AM, Ben Abbott wrote:
> 
>> On May 15, 2013, at 3:37 PM, Ben Abbott wrote:
> [snip]
>> John,
>> 
>> The patch below allows me to build&  run the gui with Qscintilla 2.4.
>> 
>> I'm in unfamiliar territory, so before I mess something up ... Is it ok to 
>> push a changeset?
> 
> In both your attached changeset and the changeset here:
> 
> http://hg.savannah.gnu.org/hgweb/octave/rev/72665c4ae25b
> 
> defining HAVE_LEXER_OCTAVE and HAVE_LEXER_MATLAB doesn't add much more 
> clarity beyond just using HAVE_QSCI_QSCILEXEROCTAVE_H and 
> HAVE_QSCI_QSCILEXERMATLAB_H.  Consider whether it is necessary.
> 
> Dan

I'll defer to jwe on that.  I had wondered about that as well and speculated 
that John may be laying the groundwork for something to come.

Ben