octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: xlsread in Octave 3.6.4


From: Philip Nienhuis
Subject: Re: xlsread in Octave 3.6.4
Date: Fri, 04 Oct 2013 14:50:38 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.11) Gecko/20100701 SeaMonkey/2.0.6

Markus wrote:
Am 2013-09-30 21:33, schrieb Philip Nienhuis:
Markus wrote:
Am 2013-09-30 20:39, schrieb Philip Nienhuis:
<snip>
Could you adapt/create these files, please?


I'll start trying that arond ~thursday/friday.

I'll start but it's not finished.

What's done:
__OCT_spsh_close__.m

https://github.com/markuman/xlsxread/blob/master/io/inst/private/__OCT_spsh_close__.m

Thanks.
Perhaps I'll turn the if-elseif into a switch statement for more clarity.

It is now using "fileparts".
This is more simply and more flexible I guess.

That depends.
To just check whether a file is Excel, e.g.,

  ## catches .xls, .xlsx, .xlsm, .xlsb
  <if> index (filename(end-4:end), ".xls")
    .... <do something>

is easier (IMO!) than

  ## Two statements needed rather than one
  [~, ~, sfx] = fileparts (filename);
  <if> ! isempty (strfind (sfx, ".xls"))
    .... <do something>

But to only catch .xlsx, fileparts may be easier, yes.

What's started but not finished yet:
__OCT_spsh_open__.m
https://github.com/markuman/xlsxread/blob/master/io/inst/private/__OCT_spsh_open__.m


What's not started
__OCT_xlsx2oct__.m

The most important one...

__OCT_getusedrange__.m

Could be done later.

__OCT_spsh_info__.m

Same. For now we could just convey the sheet names (after all, Matlab doesn't do much more). Occupied cell ranges would be nice, but not yet. If required we could just insert dummy ranges.

dos2unix stuff

dos2unix is for the very end.

Now it's time for you to nag about it.

Nag? no, at first sight it looks wonderful.

I spotted a few little bugs in the ODS code (oops); I'll fix them later in svn.

Philip


reply via email to

[Prev in Thread] Current Thread [Next in Thread]