Re: developing the delaunayTriangulation class for Octave

[Linux User]

>I cannot comment much on the implemented algorithm as I don't wnow much of 
>"ordered percolated lists",
So I will just provide a few quick comments about coding style (but );

Thank you for using my code to demonstrate proper format. I added more
information in the text description of the code.:

http://agora.octave.org/snippet/TxBp/

I still cannot post comments. When I have a moment I will start
writing the neighbors function for testing the dlf_percolate function.

On Sun, Feb 16, 2014 at 2:20 PM, c. <address@hidden> wrote:
>
> On 16 Feb 2014, at 19:47, Linux User <address@hidden> wrote:
>
>> I posted my code into agora. The link is: 
>> http://agora.octave.org/snippet/VYPd/
>>
>> I was unable to format the tabbing correctly to 2 spaces width and
>> post my comments of the code into the forum, due to a formatting
>> error. Comments are posted on:
>
> I cannot comment much on the implemented algorithm as I don't wnow much of 
> "ordered percolated lists",
> So I will just provide a few quick comments about coding style (but );
>
> 1) I posted a reformatted version of your function:
>    http://agora.octave.org/snippet/twOQ/
>
>    following more closely Octave's formatting style conventions:
>    
> http://www.gnu.org/software/octave/doc/interpreter/C_002b_002b-Sources.html#C_002b_002b-Sources
>    http://www.gnu.org/prep/standards/html_node/Writing-C.html#Writing-C
>
> 2) notice the use of the macro "print_usage" to output the docstring in case 
> input is incorrect instead of "error"
>
> 3) you should also use "error_state" to check whether the type of the input 
> parameters was correct.
>
> 4) the conventio is to return an empty octave_value_list object if input 
> validation fails,
>    not to copy he input into the output.
>
> 5) you should provide at least a demo and a few tests to validate your code:
>    
> http://www.gnu.org/software/octave/doc/interpreter/Test-and-Demo-Functions.html#Test-and-Demo-Functions
>
> In general it is also dangerous to use recursive functions, so you should 
> avoid it if possible,
> but as I don't know much about the algorithm maybe this is correct in your 
> case.
>
> HTH,
> c.
>