Re: configure.ac and Dolfin.h

[Sébastien Villemot]

Le samedi 01 mars 2014 à 14:12 +0100, Juan Pablo Carbajal a écrit :
> On Sat, Mar 1, 2014 at 2:07 PM, Juan Pablo Carbajal
> <address@hidden> wrote:
> > On Sat, Mar 1, 2014 at 7:43 AM, c. <address@hidden> wrote:
> >>
> >> On 1 Mar 2014, at 04:51, Juan Pablo Carbajal <address@hidden> wrote:
> >>
> >>> I just committed a change to bootstrap and configure.ac such that it
> >>> accepts --with-dense-includedir
> >>
> >> Hey, aren't you the one who likes to go ranting around about obscure names?
> >>
> >> I'd rather use --with-eigen or --with-eigen3 as a name for the option.
> >>
> >> Dense is just one out of many headers in the Eigen3 package,
> >> users will install Eigen3 not just pick one header out of the distribution
> >> and place it somewhere.
> >>
> >>
> >>> to indicate special locations for
> >>> Eigen/Dense. Only then checks are performed. Please verify that it
> >>> works.
> >>
> >> But how do you pass these flags when doing "pkg install -forge" ?
> >>
> >> And how can they be informed that the option exists if they cannot run
> >> configure --help?

> > I found the error when including Eigen/Dense, therefore for me "dense"
> > wasn't an obscure name. I will change that, not an issue.
> >
> > Be patient my friend. The old-new pkg (lol!) was designed to receive
> > this optional arguments but it was never implemented. We need to
> > revive that code...is out there and still working :D
> >
> > Now all the handles are in place, one would need to think how to make
> > pkg return package specific help. Maybe
> > pkg -help pkg_name
> > (I think it already accepts this...gotta check again)
> 
> Done, now configure accepts --with-eigen-includedir

Why not instead (or in addition to that) use the output of pkg-config?
This is the standard way to detect flags to be added when
compiling/linking against a library.

On my Debian unstable system, the eigen3 include directory is included
in the output of "pkg-config --cflags dolfin".

-- 
 .''`.    Sébastien Villemot
: :' :    Debian Developer
`. `'     http://www.dynare.org/sebastien
  `-      GPG Key: 4096R/381A7594

signature.asc
Description: This is a digitally signed message part