Re: compilable gui-release revision?

[Torsten]

On 23.06.2014 21:59, Torsten wrote:
> On 23.06.2014 21:46, Mike Miller wrote:
>> On Mon, Jun 23, 2014 at 21:43:08 +0200, Torsten wrote:
>>> On 23.06.2014 21:19, Dmitri A. Sergatskov wrote:
>>>> On Mon, Jun 23, 2014 at 1:53 PM, Olaf Till <address@hidden
>>>> <mailto:address@hidden>> wrote:
>>>>
>>>>     Can someone tell me a recent revision of gui-release which compiled
>>>>     for him? (0a66861d8069 from 22/06/2014 15:42 does not compile for me.)
>>>>
>>>>     Olaf
>>>>
>>>>
>>>>
>>>> Seems to work for me:
>>>> <<<<
>>>> ...
>>>> Octave successfully built.  Now choose from the following:
>>>>
>>>>    ./run-octave    - to run in place to test before installing
>>>>    make check      - to run the tests
>>>>    make install    - to install (PREFIX=/usr/local)
>>>>
>>>> make[2]: Leaving directory `/d2/home/dima/src/octave'
>>>> make[1]: Leaving directory `/d2/home/dima/src/octave'
>>>> address@hidden octave]$ hg head
>>>> changeset:   18854:0a66861d8069
>>>> branch:      gui-release
>>>> tag:         tip
>>>> parent:      18848:b314efd58072
>>>> user:        Torsten <address@hidden <mailto:address@hidden>>
>>>> date:        Sun Jun 22 15:42:00 2014 +0200
>>>> summary:     implementation of search in selection in gui editor (bbug
>>>> #41196)
>>>>
>>>>>>>>
>>>
>>> Maybe you need to bootstrap and configure due to changes in the ac-files.
>>
>> I have not tried building, but rev 0a66861d8069 looks a little
>> suspicious in that it declares slots in the find_dialog class that are
>> then conditionally compiled depending on the Qscintilla version. If
>> the slots are always declared, they should always be defined as well,
>> and the ifdef be inside the function body if needed.
>>
> 
> Oops, you are completely right. I forgot the ifdefs in the header file.
> 

I have fixed this with cset
http://hg.savannah.gnu.org/hgweb/octave/rev/fc0f3b6c37a9

Torsten