On 08 Apr 2015, at 15:21, Mike Miller <address@hidden> wrote:
On Wed, Apr 08, 2015 at 12:20:02 +0000, Eugenio Gianniti wrote:
I’ve never really caught the role of those macros, but for backward
compatibility it might be better to check the version of Octave
fem-fenics is being compiled against in the configure script, then
remove the macros based on this information, or leave them in place
and define an empty macro to make the compiler happy. I guess the best
approach is to do as other maintainers did in their packages. What is
the common practice in this matter?
Here's what I did:
http://hg.code.sf.net/p/octave/communications/rev/dd3e0dc1cd05
HTH,
--
mike
Thanks. I will prepare a changeset and push it to the repo today or tomorrow, then.
Eugenio
The patch [1] has been pushed to the repository. It uses the approach suggested by Mike.
|