[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: lsqnonlin and nonlin_residmin
From: |
Asma Afzal |
Subject: |
Re: lsqnonlin and nonlin_residmin |
Date: |
Tue, 11 Aug 2015 18:01:27 +0100 |
Hi Olaf,
Thank you for your detailed response.
> Chiefly option handling and option documentation, these seem not yet
> complete to me (only looked at lsqnonlin). In particular, there is no
> option documentation (of applicable optimset options).
I have added the documentation for options in [1].
> - You provide some Matlab-lsqnonlin-specific options, but not
> all. What will you tell the user about this?
> - Is it worth trying to map further Matlab-lsqnonlin-specific options
> to nonlin_residmin options?
I have added Display, OutputFcn and FunValCheck.
It would be a nice addition to have DerivativeCheck option as explained in [2].
Additional options such as TolX, MaxFunEvals, DiffMinChange and
DiffMaxChange, I presume, could be straight forward additions.
Remaining ones are Diagnostics and PlotFcn.
> - Currently you pass all set options to nonlin_residmin, even those
> that Matlabs lsqnonlin doesn't even know of. I don't think that's
> good, since nonlin_residmin options might conflict with Matlab
> options (as already is the case for "lbound" and "ubound"). I'd say
> rather make a new settings structure and populate it only with the
> options corresponding (e.g. by mapping) to those which Matlabs
> lsqnonlin supports.
Done in [1].
For Display I'm passing "iter" for "iter-detailed", "final", "final-detailed"
> - You document exitflag==-1 as 'Output function terminated the
> algorithm.' but the Matlab option 'OutputFcn' is not mapped (to
> 'user_interaction'), so it has no effect.
I have implemented that in [1]. Could you please check?
> A few further minor things to be changed:
>
> - docs, third output: not EuclidianNorm, just f(x)
>
> - 'sumsq (residmin_out{2})' is better than 'sum (residmin_out{2} .^ 2)'
>
> - There is no exitflag of '1'.
Done.
>
>> Should I submit a patchset on savannah?
>
> Why this if you already have a VCS?
> If the functions are ready, or require only minor changes which I can
> do while reviewing, I'll adjust the optim packages info and commit the
> functions for you.
I thought this is probably the right way to submit functions.
Anyway, thanks for doing the adjustments.
Kind Regards,
Asma.
[1] https://github.com/AsmaAfzal/octave_workspace/blob/master/lsqnonlin.m
[2]
http://uk.mathworks.com/help/optim/ug/checking-validity-of-gradients-or-jacobians.html
- Re: lsqnonlin and nonlin_residmin, (continued)
- Re: lsqnonlin and nonlin_residmin, Nir Krakauer, 2015/08/05
- Re: lsqnonlin and nonlin_residmin, Olaf Till, 2015/08/05
- Re: lsqnonlin and nonlin_residmin, Asma Afzal, 2015/08/05
- Re: lsqnonlin and nonlin_residmin, Nir Krakauer, 2015/08/05
- Re: lsqnonlin and nonlin_residmin, Olaf Till, 2015/08/05
- Re: lsqnonlin and nonlin_residmin, Olaf Till, 2015/08/06
- Re: lsqnonlin and nonlin_residmin, Asma Afzal, 2015/08/07
- Re: lsqnonlin and nonlin_residmin, Nir Krakauer, 2015/08/07
Re: lsqnonlin and nonlin_residmin, Asma Afzal, 2015/08/10