Re: error: cannot pass object of non-POD type 'std::string' through variadic function

[Ben Abbott]

Thanks John,

I’m able to build again.

Ben

> On Dec 8, 2015, at 8:18 PM, Ben Abbott <address@hidden> wrote:
> 
> John, I’m seeing another error when building on Mac OS.
> 
> I encountered the errors below from tip 7883f240d8ea
> 
> libinterp/builtins.cc is unchanged
>  CXX      libinterp/corefcn/libinterp_corefcn_libcorefcn_la-error.lo
> libinterp/corefcn/error.cc:954:51: error: cannot pass object of non-POD type 
> 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char> >') 
> through variadic function;
>      call will abort at runtime [-Wnon-pod-varargs]
>              rethrow_error (id.c_str (), "%s\n", tmp_msg);
>                                                  ^
> libinterp/corefcn/error.cc:958:43: error: cannot pass object of non-POD type 
> 'std::string' (aka 'basic_string<char, char_traits<char>, allocator<char> >') 
> through variadic function;
>      call will abort at runtime [-Wnon-pod-varargs]
>        rethrow_error (id.c_str (), "%s", tmp_msg);
>                                          ^
> 2 errors generated.
> Makefile:17138: recipe for target 
> 'libinterp/corefcn/libinterp_corefcn_libcorefcn_la-error.lo' failed
> make[2]: *** [libinterp/corefcn/libinterp_corefcn_libcorefcn_la-error.lo] 
> Error 1
> make[2]: Leaving directory 
> '/Users/bpabbott/Development/mercurial/default/sources'
> Makefile:25839: recipe for target 'all-recursive' failed
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory 
> '/Users/bpabbott/Development/mercurial/default/sources'
> Makefile:9920: recipe for target 'all' failed
> make: *** [all] Error 2
> 
> After reverting  779898f2a02a, I’m able to build again.
> 
>       hg revert --rev 779898f2a02a libinterp/corefcn/error.cc
> 
> I’m running Mac OS 10.10.5, and am using Apple’s clang
> 
> Apple LLVM version 7.0.0 (clang-700.1.76)
> Target: x86_64-apple-darwin14.5.0
> Thread model: posix
> 
> Ben
> 
>