octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gplot.txt


From: Ben Abbott
Subject: Re: gplot.txt
Date: Mon, 07 Mar 2016 20:23:39 -0500

> On Mar 7, 2016, at 2:31 PM, Rik <address@hidden> wrote:
> 
> Ben, Dan, Lachlan,
> 
> I checked in this cset
> http://hg.savannah.gnu.org/hgweb/octave/rev/9f7282acc30f to resolve the
> segfaults with speye on Mac platforms.
> 
> I made the minimum fix necessary: removing the use of the OCTAVE_NORETURN
> attribute in a single instance and adding a useless return statement to the
> previously decorated function in order to suppress the compilation
> warning.  If further problems develop then we should take the other tack
> and explicitly distinguish between GCC and clang in the macros that test
> for GCC.
> 
> Cheers,
> Rik

Hi Rik,

This NORETURN stuff is outside my comfort zone. While I started out skeptical 
of the idea of only fixing this one case, I am happy to report that I’ve 
competed a build with no crashes. Its been weeks since that happened (I 
typically encounter several crashes as the docs are built). So although I’ll 
need to do more testing, my initial impression is positive.

I’ll try “make check” and report back.

Ben
 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]