Re: libgui/src/files-dock-widget.cc: unnecessary translated strings?

[John W. Eaton]

On 09/20/2016 03:59 AM, Andreas Weber wrote:
> Dear maintainers,
>
> libgui/src/files-dock-widget.cc:82
>   _columns_shown_keys.append (tr ("filesdockwidget/showFileSize"));
>   _columns_shown_keys.append (tr ("filesdockwidget/showFileType"));
>   _columns_shown_keys.append (tr ("filesdockwidget/showLastModified"));
>   _columns_shown_keys.append (tr ("filesdockwidget/showHiddenFiles"));
>   _columns_shown_keys.append (tr
> ("filesdockwidget/useAlternatingRowColors"));
>
> As far as I understand the code, these strings are used as keys and not
> visible to the user. So is it save to remove the tr ()?

Yes, if they are translated, then the settings they refer to wouldn't be 
found?  So I think you are right that they shouldn't be tagged with tr().

jwe