Re: new ODE functions

[Rik]

On 12/16/2016 09:00 AM, address@hidden wrote:

Subject:

Re: pushing code from GSOC projects (WAS: Re: Default merged to stable for upcoming 4.2 release)

From:

"c." <address@hidden>

Date:

12/16/2016 02:38 AM

To:

Carlo de Falco <address@hidden>

CC:

Marco Caliari <address@hidden>, Jacopo Corno <address@hidden>, address@hidden, address@hidden, Sebastian Schöps <address@hidden>, Francesco Faccio <address@hidden>, "John W. Eaton" <address@hidden>, Octave Maintainers List <address@hidden>

List-Post:

<mailto:address@hidden>

Content-Transfer-Encoding:

7bit

Precedence:

list

MIME-Version:

1.0 (Mac OS X Mail 7.3 \(1878.6\))

References:

<address@hidden> <address@hidden> <address@hidden>

In-Reply-To:

<address@hidden>

Message-ID:

<address@hidden>

Content-Type:

text/plain; charset=us-ascii

Message:

1

On 29 Nov 2016, at 15:56, c. <address@hidden> wrote:



I will now start working more thoroughly on improving the coding style,
but I would really appreciate if someone could look in detail at this
code, especially the autoconf part, and suggest changes/improvements.

c.

Carlo,

Can you modify scripts/help/__unimplemented__.m to remove ode15i, ode15s from the list of functions missing from Octave?  There is also a more explanatory help message that needs updating.

    case {"ode113", "ode15i", "ode15s", "ode23s", "ode23t", "ode23tb"}
      txt = ["Octave provides lsode and ode45 for solving differential equations. ", ...
             "For more information try @code{help lsode}, @code{help ode45}.  ", ...
             "Matlab-compatible ODE functions are provided by the odepkg ", ...
             "package.  See @url{http://octave.sourceforge.net/odepkg/}."];

Other things I see are single quotes instead of double quotes in some of the code.

For the input validation %!error tests I would use a message so it is clear what is being tested.  This is an example from ode45.m

%!error <TRANGE must be a numeric> ode45 (@fpol, {[0 25]}, [3 15 1])

instead of writing

%!error ode45 (@fpol, {[0 25]}, [3 15 1])

When I run configure, I get

configure: WARNING: SUNDIALS_IDA library configured with klu not found. Solvers ode15i and ode15s will be disabled.
configure: WARNING: SUNDIALS_NVECSERIAL library not found. Solvers ode15i and ode15s will be disabled.

For text, the convention is to use two spaces after a period to indicate a sentence break.  Also, printing just one message that the solvers will be disabled is enough.

--Rik