[Octave-patch-tracker] [patch #7468] Wrapper for OSX libBLAS.dylib and libLAPACK.dylib

[John W. Eaton]

Follow-up Comment #1, patch #7468 (project octave):

Do you object to licensing the copy of this file that is distributed with
Octave under the terms of the GPLv3 or any later version, and changing the
notice to say that this file is part of Octave?

I would also make the following changes:

Use a macro to define the location of the vecLib file so that it can be easily
changed if needed:


#ifndef VECLIB_FILE
#define VECLIB_FILE "/System/Library/..."

...

  apple_vecLib = dlopen (VECLIB_FILE, ...);


Use only C style comments since this is a C language file, not C++.

Include <stdlib.h> for the declaration of abort.

Untabify the file.

Can you also explain why the +1 in


static void (*f2c_lapack_func[f2c_LAPACK_COUNT+1])(void) = { 0 };


avoids the GCC warning "array subscript is above array bounds"?  I don't
understand how f2c_LAPACK_COUNT+1 would not be above the array bounds if
f2c_LAPACK_COUNT by itself is above the array bounds.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?7468>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/