[Octave-patch-tracker] [patch #9281] Image package: imsharpen

[Carnë Draug]

Follow-up Comment #5, patch #9281 (project octave):

I first made a bunch of style changes (see inlined comments):

https://bitbucket.org/carandraug/octave-image/commits/da6638b3ce30000abbd148d5f64b82ff7f29cb17

And then this for reduced memory usage and performance

https://bitbucket.org/carandraug/octave-image/commits/447fa23083a2187e88aad4672b6d87504319e339

Reuse existing variables with inplace operators (less memory and faster
operations). Also, instead of multiplying by a logical matrix to set elements
to zero, it's better to just use the logical matrix to index and assign values
to zero.

The failing tests are all for rgb images. Does the Matlab incompatibilities
come from rgb2lab or maybe lab2rgb?  Sounded like it from comment #3.  Could
we make those failing tests there too?



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9281>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/