[Octave-patch-tracker] [patch #9494] Patches for polygon2patch & joinPolygns

[Philip Nienhuis]

Follow-up Comment #2, patch #9494 (project octave):

Some answers:

- The whole file had CRLF end-of-lines that were changed into just LF by the
cset.
I suppose they now still have CRLF? or was that a glitch in my local repo,
could be.

- I did a pull ("hg -v pull" and "hg -v update -C") before creating the cset.
Afterwards I was warned about multiple heads, one regarding a huge commit, the
other regarding __dbl2int64__. I have no idea where those multiple heads come
from.

- joinPolygons passed all 4 tests on my box. ???

- I think joinPolygons should either accept two column vectors (X and Y) OR
just one Nx2 (XY) or Nx3 (XYZ) matrix. It shouldn't accept two matrices or a
matrix and a vector.
Would you like me to add another input check for that case?

On a related note, I provisionally added polybool, polycut and polyjoin to
mapping (all Matlab compatibility wrappers for similar functions in geometry)
but I'd be equally happy (or even slightly happier) if they lived in the
geometry package. I needed them on short notice so they're just in my local
build.
A while ago you wrote that maybe a Matlab-comaptible subdir in geometry could
host those function files. Still want that? if so I can prepare a patch for
that as well as soon as I know a name for such subdir.

Either way, I'd like to make a mapping pkg release before the end of 2017 as I
have fixed many bugs in the shapefile routines and several new functions were
added.  As mapping depends on geometry and some patches are required for
geometry (polygon2patch & joinPolygons), maybe a maintenance release of
geometry would be in order as well. What do you think of that?


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9494>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/